What is the "Day Time" Logic for Theme "Auto"? #1433
-
General Information
Question
ExperienceThe sun had long since risen, but app still determined Auto should result in Dark mode. Later, the app had begun to determine Auto should result in Light mode. BackgroundHow Theme Does Not WorkThe Theme “Auto” does not trigger based on recent UI guidelines, because the “current implementation works in the same way for any OS version” (for simplicity). How Theme Works (Simplified)The "auto mode is [determined] by day time, nothing else". Related Issues |
Beta Was this translation helpful? Give feedback.
Replies: 2 comments
-
|
The logic is based on hours -> https://github.com/gsantner/markor/blob/master/app/src/main/java/net/gsantner/markor/util/AppSettings.java#L69. Why? This Android own feature is pretty new, and many devices dont support it yet. It's an effort to support both "the new" and have a fallback that just works everywhere. So instead, we just have something that "just works everywhere". If somebody wants to put time into this, and provide a COMPLETE solution for current and old devices, please do so and make a pull request. I won't do this. |
Beta Was this translation helpful? Give feedback.
-
|
9 am to 5 pm. Thank you.
…On Mon, Sep 13, 2021, 08:25 Gregor Santner ***@***.***> wrote:
The logic is based on hours ->
https://github.com/gsantner/markor/blob/master/app/src/main/java/net/gsantner/markor/util/AppSettings.java#L69
.
Why? This Android own feature is pretty new, and many devices dont support
it yet. It's an effort to support both "the new" and have a fallback that
just works everywhere. So instead, we just have something that "just works
everywhere".
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#1433 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAY3YMUS2BX26VQSGZZGFQLUBX3VDANCNFSM5DZQOGGQ>
.
|
Beta Was this translation helpful? Give feedback.
The logic is based on hours -> https://github.com/gsantner/markor/blob/master/app/src/main/java/net/gsantner/markor/util/AppSettings.java#L69.
Why? This Android own feature is pretty new, and many devices dont support it yet. It's an effort to support both "the new" and have a fallback that just works everywhere. So instead, we just have something that "just works everywhere".
If somebody wants to put time into this, and provide a COMPLETE solution for current and old devices, please do so and make a pull request. I won't do this.