Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RfT: Icons for MBTA support #865

Closed
4 tasks done
doctormo opened this issue May 31, 2023 · 5 comments
Closed
4 tasks done

RfT: Icons for MBTA support #865

doctormo opened this issue May 31, 2023 · 5 comments
Labels
enhancement 🏗️ A functional improvement.

Comments

@doctormo
Copy link

Acknowledgments
Please check the following boxes with an x if they apply:

  • The feature I want to propose would be useful for the majority of users, not only for me personally.
  • I am aware that Transportr is mostly developed by one person in their unpaid spare time.
  • I can help myself to get this feature implemented or know someone who wants to do it.
  • If I want to add support for a new region or country, I checked that this is already available in public-transport-enabler and know the process described on the Transportr homepage.

Is your feature request related to a problem? Please describe.

I would like to have support for Massachusetts MBTA, it is listed in public-transport-enabler, although the API available for MBTA data looks different than the one inhertied in PTE ( https://www.mbta.com/developers/v3-api vs https://github.com/schildbach/public-transport-enabler/blob/master/src/de/schildbach/pte/MassachusettsProvider.java )

Describe the solution you'd like

I am an Inkscape developer ( https://www.youtube.com/watch?v=g4-0CjRwmgE ) and would like to help Transportr with some icons. You require SVGs which are then converted into Android image formats and I believe I could help make them pretty and consistent. Especially the ones for the USA which do not appear to have had much love.

Describe alternatives you've considered

I looked at the code. Theoretically I could learn programming in Java again... but I really really don't want to. It messes with my C++ and python brain.

Additional context

Please let me know if this is an equitable trade and if you have a priority list of icons you want tackled first. I would do the work by your instruction.

@doctormo doctormo added the enhancement 🏗️ A functional improvement. label May 31, 2023
@Altonss
Copy link
Collaborator

Altonss commented Jun 3, 2023

Thanks for your message!
So if I understand correctly you propose 2 things:

  • request to add MBTA network
  • work on USA svg icons
    If thats the case, maybe it would be better to separate the USA svg icons update in a separate issue.
    You can look at existing or past PRs about svg icons update to understand better how it has been done :)

@Altonss Altonss added the needs info ℹ️ More information needed, label Jun 3, 2023
@doctormo
Copy link
Author

doctormo commented Jun 3, 2023

Not just the USA svg icons. Whichever ones you or grote or whomever would like to be worked on. I would be at your direction in this work trade. I only used them as an example.

This issue can be closed if we either reach an agreement to trade skills, or don't. It should spawn two issues, one for me and one for the programmer who adds the functionality.

@Altonss
Copy link
Collaborator

Altonss commented Jun 3, 2023

Transportr is currently first focusing on basic maintenance (see #852), so updating SVGs isn't a high priority in my opinion. Feel free to open PRs if you see any icons you want to update, but I think the spirit of Transportr is rather to keep it simple :)

I you agree with it, I will open a clean new issue about adding Massachusetts network and close this one.

@doctormo
Copy link
Author

doctormo commented Jun 3, 2023

Understood. Thanks for responding quickly.

@Altonss
Copy link
Collaborator

Altonss commented Dec 6, 2023

With the latest cleanup of networks #877, only 3 networks are remaining in the USA and their SVGs seem all fine. So I'll close the issue for now.

@Altonss Altonss closed this as not planned Won't fix, can't repro, duplicate, stale Dec 6, 2023
@Altonss Altonss removed the needs info ℹ️ More information needed, label Dec 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement 🏗️ A functional improvement.
Projects
None yet
Development

No branches or pull requests

2 participants