Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] graphite-web 1.1.8+ dependency on pyparsing misses version requirement #2834

Open
timmooney opened this issue Apr 18, 2024 · 2 comments
Open

[BUG] graphite-web 1.1.8+ dependency on pyparsing misses version requirement #2834

timmooney opened this issue Apr 18, 2024 · 2 comments
Labels
bug

Comments

@timmooney
Copy link

I'm attempting to update a working install of whisper/carbon/graphite-web from 1.1.5 to current latest. Once I'm on a more recent version, I'll be moving my install to a newer system & Python3, but for now I have to get the current version upgraded.

My working install with 1.1.5 is using pyparsing 2.2.0.

I've discovered that graphite-web 1.1.8 and 1.1.10 will not work with that version of pyparsing. At 1.1.8 webapp/graphite/render/grammar.py goes away and is replaced by webapp/graphite/render/grammar_unsafe.py.

The new grammar_unsafe.py still uses pyparsing, but its import now also requires pyparsing_unicode.

pyparsing_unicode was introduced in pyparsing version 2.3.0. See: pyparsing CHANGES

It looks like the requirements.txt file was updated to note the dependency (for pip, I assume?), but other places were not.

Two things should be updated:

  1. The Dependencies documentation for graphite should be updated to list pyparsing >= 2.3.0. Currently other python module dependencies are mentioned, but pyparsing isn't listed at all.
  2. The check_dependencies.py script is checking for any version of pyparsing and isn't detecting an installed version that predates pyparsing_unicode.

I'm not wise in the ways of Python, but it's possible the tox.ini also may need updates?
@timmooney timmooney added the bug label Apr 18, 2024
@deniszh
Copy link
Member

deniszh commented Aug 24, 2024

That's bug in dependencies, indeed. 1.1.8 is not latest, though, will check if happens on latest code

deniszh added a commit to deniszh/graphite-web that referenced this issue Aug 25, 2024
@deniszh
Fix pyparsing dep version (fixing graphite-project#2834)
c4dcf0f
deniszh added a commit that referenced this issue Aug 25, 2024
@deniszh
Django 4.2 support (#2846)
66dcd48 
* Adding django-upgrade pre-commit

* Submitting django upgrade result

* Include test suite in release (fixing #2830)

* Fix pyparsing dep version (fixing #2834)

* Upgrade Django and python version in reqs and tox

* adding dependabot

* adding new python in tests

* Comment out broken tests

* fix attime tests for python 3.12

* fix more tests for python 3.12

* simplify tox

* fix self.assertRegex test

* fix self.assertRegex test

* fix self.assertEquals test

* pleasing linter

* more pleasing linter

* trying to fix events test

* let's keep doc on py310

* more event test fixes

* moving doc to 3.10

* ok, moving back
@timmooney
Copy link
Author

That's bug in dependencies, indeed. 1.1.8 is not latest, though, will check if happens on latest code

You're correct. The new requirement / missing dependency happened at version 1.1.8, but even the latest docs and check_dependencies.py don't include it.

Thanks for taking a look at the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@deniszh @timmooney