Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Retry git pull on error #61

Closed
szkiba opened this issue Sep 10, 2024 · 1 comment · Fixed by #62
Closed

Retry git pull on error #61

szkiba opened this issue Sep 10, 2024 · 1 comment · Fixed by #62
Assignees
@szkiba

Comments

@szkiba
Copy link
Collaborator

szkiba commented Sep 10, 2024 •
edited
Loading

In the git working directory, the file permissions are changed to make the cache persistent in GitHub action mode. As a consequence, the git pull operation will fail (if permissions have actually been changed).

To fix this, if the pull operation fails, the pull operation is repeated after a forced checkout operation.

grafana/k6-ext-tooling#34
@szkiba szkiba self-assigned this Sep 10, 2024
@szkiba szkiba linked a pull request Sep 10, 2024 that will close this issue
fix: retry git pull on error #62
Merged
@szkiba
Copy link
Collaborator Author

szkiba commented Sep 10, 2024

In addition to ErrWorktreeNotClean the ErrUnstagedChanges should handle as well.

@szkiba szkiba reopened this Sep 10, 2024
@szkiba szkiba closed this as completed Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@szkiba szkiba

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: retry git pull on error grafana/k6registry
1 participant
@szkiba