Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

celluloid doesn't install with requirements #12

Open
andrzejnovak opened this issue Apr 28, 2020 · 3 comments
Open

celluloid doesn't install with requirements #12

andrzejnovak opened this issue Apr 28, 2020 · 3 comments

Comments

@andrzejnovak
Copy link
Contributor

No description provided.

@phinate phinate mentioned this issue Apr 29, 2020
Merged
@andrzejnovak
Copy link
Contributor Author

Shouldn't jupyter and nbdev also be part of requirements?

@phinate
Copy link
Member

phinate commented May 18, 2020

These are technically dev-only requirements (theyre also installed by default in the CI), but it is probably sensible to add at least jupyter, or explain this in CONTRIBUTING. Thanks!

@andrzejnovak
Copy link
Contributor Author

Yup, adding it to CONTRIBUTING makes sense to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@andrzejnovak @phinate