Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Find a way to get the correct JDK to build mandrel #59

Open
zakkak opened this issue Sep 16, 2020 · 0 comments
Open

Find a way to get the correct JDK to build mandrel #59

zakkak opened this issue Sep 16, 2020 · 0 comments
Labels
enhancement New feature or request not-stale

Comments

@zakkak
Copy link
Collaborator

zakkak commented Sep 16, 2020

Graal as well as Mandrel are tightly coupled to the OpenJDK used to build them. As we push out new releases it would be nice to be able to keep track of a map from Mandrel versions to OpenJDK versions so that in the future we can come back and build an older version using the OpenJDK that was available at the time.

Graal uses https://github.com/graalvm/mandrel/blob/graal/master/common.json to keep such info in the sources. This file gets updated as new JDK's become available etc.

Following a similar approach would enable us to checkout at any time any version and using mandrel-packaging build mandrel with the correct JDK version, e.g. if you try to build 20.1.0.2 it would use 11.0.8-GA but if you try to build say 20.1.0.5 it would use 11.0.9-GA etc.

We can even have something similar to graalvm with JAVA_HOME and EXTRA_JAVA_HOMES to define more than one JDK versions that are known to work with the corresponding mandrel version (or that we would like to test, although this won't work right in GH actions, but maybe Jenkins can take advantage of it)

@zakkak zakkak added the enhancement New feature or request label Sep 16, 2020
@github-actions github-actions bot added the Stale label Oct 17, 2020
@jerboaa jerboaa removed the Stale label Oct 19, 2020
@github-actions github-actions bot added the Stale label Nov 18, 2020
@zakkak zakkak removed the Stale label Nov 18, 2020
@github-actions github-actions bot added the Stale label Dec 19, 2020
@jerboaa jerboaa removed the Stale label Dec 21, 2020
@github-actions github-actions bot added the Stale label Jan 21, 2021
@zakkak zakkak removed the Stale label Jan 21, 2021
@github-actions github-actions bot added the Stale label Feb 21, 2021
@jerboaa jerboaa removed the Stale label Feb 22, 2021
@graalvm graalvm deleted a comment from github-actions bot Feb 22, 2021
@graalvm graalvm deleted a comment from github-actions bot Feb 22, 2021
@graalvm graalvm deleted a comment from github-actions bot Feb 22, 2021
@graalvm graalvm deleted a comment from github-actions bot Feb 22, 2021
@graalvm graalvm deleted a comment from github-actions bot Feb 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request not-stale
Projects
None yet
Development

No branches or pull requests

2 participants