-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Protobuf examples for mobile #518
Comments
Yeah I do plan on adding Kotlin to the Protobuf tutorial. |
An example of how to Get All Available Presets using RequestGetPresetStatus would be great! |
Is the confusion here about the additional Open GoPro packet wrapping around Protobuf? Or simply how to compile / build protobuf messages? The latter is mostly out of the scope of Open GoPro and covered pretty extensively by Protobuf.dev |
@tcamise-gpsw It would be great just to have some Kotlin example in tutorials to perform actions like in this tutorial for Python, not necessarily a complete wrapper Maybe adding it as an additional file to the Kotlin Example here: |
@tcamise-gpsw I've managed to implement COHN provisioning for Kotlin. My Protobuf encoding works fine, but my parsing logic is not generic at all; I've just hardcoded it using regular expressions. I haven’t worked with Protobuf before, but as I understand it, parsing is just the opposite operation to encoding (packetizing). Before trying to implement the parsing, I would like to clarify—how does the Python SDK differentiate Query Response Types? Specifically, how do we know that the response is a Protobuf? I couldn't understand that from the library in a reasonable amount of time. Are we supposed to know which type of response we are waiting for, considering the command sent? By the way, here is how my encoding works. FeatureId(0x02) ActionId(0x05) and FieldNumbers (1,2) are hardcoded for simplicity.
|
Nice! I'm about to start working on this ticket so I'll take a look at your code above when I get around to it. Yes your understanding of general protobuf parsing sounds correct. |
FYI I'm working on a Kotling KMP SDK which will be similar in scope to the current Python SDK. I'm not sure if the tutorials as currently constructed are going to be worthwhile once we have both of these SDK's. Ideally tutorials instead could use the various SDK's to focus on higher level concept such as streaming, presets, etc. Any opinion here? |
Hi! would be really cool to see some examples of using protobuf commands on IOS or Android. Are there any plans to add it? Would be super useful with this new COHN feature
The text was updated successfully, but these errors were encountered: