Rolling updates do not progress if all game servers in the fleet are in the Allocated state
#3970
Labels
kind/bug
These are bugs.
Comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Within the agones
Fleetcontroller logic, we do not allow scaling the replica count above the specified amount of replicas. Seeagones/pkg/fleets/controller.go
Line 501 in 3e18f4f
MaxSurgeworks in other k8s entities such asDeployment, since in the latter the number of replicas can scale up while the redeployment is happening. Also, not being able to scale up the replica count during the rolling update implies that, if all theGameServers are in allocated mode, theRollingUpdatewill not happen until at least one of theGameServers dies or transitions back intoReadystate. In cases in which the users of Agones need to use theoverflowevent during theRollingUpdateto control the allocations based on certain labels, the allocations will constantly fail since theRollingUpdateis not capable of creating more replicas and theoverflowevent has been processed by theGameServers.Adding a flag to allow scaling up the fleet replica count would not be a lot of work (since I guess we do not want to change the meaning of the
RollingUpdateparameters for backwards compatibility reasons). That said, I'm not familiar enough with the codebase to understand the consequences of the the fleet replica count increasing above the specified count. This could also impact theFleetAutoscaler.The text was updated successfully, but these errors were encountered: