Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: adds integration tests for Universe Domain configuration #2538

Open
wants to merge 29 commits into
base: main
Choose a base branch
from
Open

feat: adds integration tests for Universe Domain configuration #2538

wants to merge 29 commits into from
+79 −3

Conversation

thiyaguk09
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes

thiyaguk09 and others added 22 commits September 6, 2024 15:26
@thiyaguk09
feature added
e28ce5f
@thiyaguk09
fix
83de827
@thiyaguk09
Added system test and sample test cases
828b645
@thiyaguk09
copyright fix
164975a
@thiyaguk09
Merge pull request #1 from thiyaguk09/googleapis#2138-feature-add-'fi…
f6f8e48 
…elds'-to-getFiles

feat(storage):  add support for 'fields' query parameter to getFiles
@thiyaguk09
Merge branch 'main' of https://github.com/thiyaguk09/nodejs-storage-fork
b466a7d
@thiyaguk09
build: fix path-to-regexp to older version due to node 14 requirement
41261d8
@thiyaguk09
Merge pull request #2 from thiyaguk09/googleapis#2138-feature-add-'fi…
99e7acd 
…elds'-to-getFiles

build: fix path-to-regexp to older version due to node 14 requirement
@gcf-owl-bot
🦉 Updates from OwlBot post-processor
65aaf97 
See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md
@thiyaguk09
Remove unnecessary sample code
5b1a681
@thiyaguk09
Merge pull request #3 from thiyaguk09/googleapis#2138-feature-add-'fi…
af6adf9 
…elds'-to-getFiles

Remove unnecessary sample code
@thiyaguk09
Merge branch 'main' of https://github.com/thiyaguk09/nodejs-storage-fork
5336628
@thiyaguk09
Manually modify README regards remove unnecessary sample code
e93bc98
@thiyaguk09
Merge branch 'googleapis:main' into main
080d0ec
@thiyaguk09
added 'skipIfExists' option for downloadMany
c5a801a 
Node Transfer Manager: add support for 'skipIfExists' option for
downloadMany
@thiyaguk09
Merge branch 'googleapis:main' into skipIfExists-option-for-downloadM…
4be3987 
…any-in-transfer-manager
@harsha-accenture
Merge pull request #4 from thiyaguk09/skipIfExists-option-for-downloa…
2024c44 
…dMany-in-transfer-manager

feat(storage): add support for 'skipIfExists' option for downloadMany
@thiyaguk09
Merge branch 'googleapis:main' into main
5804659
@thiyaguk09
feat: adds integration tests for Universe Domain configuration
53aab1e
@thiyaguk09
feat: adds integration tests for Universe Domain configuration with k…
e45a650 
…okoro

feat: adds integration tests for Universe Domain configuration with
kokoro changes
@thiyaguk09
remove only test lint fix
5b1ff10
@thiyaguk09
Merge pull request #5 from thiyaguk09/universe-domain-add-integration…
2275d56 
…-tests

feat: adds integration tests for Universe Domain configuration
@thiyaguk09 thiyaguk09 requested review from a team as code owners September 30, 2024 06:51
@product-auto-label product-auto-label bot added the size: m Pull request size is medium. label Sep 30, 2024
@generated-files-bot Generated Files Bot
Copy link

Warning: This pull request is touching the following templated files:

  • .kokoro/continuous/node14/system-test.cfg - .kokoro files are templated and should be updated in synthtool
  • .kokoro/presubmit/node14/system-test.cfg - .kokoro files are templated and should be updated in synthtool
  • .kokoro/release/publish.cfg - .kokoro files are templated and should be updated in synthtool
  • .kokoro/system-test.sh - .kokoro files are templated and should be updated in synthtool

@product-auto-label product-auto-label bot added the api: storage Issues related to the googleapis/nodejs-storage API. label Sep 30, 2024
@thiyaguk09 thiyaguk09 added the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 30, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 30, 2024
@ddelgrosso1
Copy link
Contributor

Code looks good, think the after hook needs some adjustment as it is failing.

@thiyaguk09
Copy link
Contributor Author

Code looks good, think the after hook needs some adjustment as it is failing.

The after hook has been adjusted. Please review the changes.

@ddelgrosso1 ddelgrosso1 added the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 3, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 3, 2024
@thiyaguk09 thiyaguk09 requested a review from a team as a code owner October 3, 2024 13:38
@ddelgrosso1 ddelgrosso1 added the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 3, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 3, 2024
ddelgrosso1
ddelgrosso1 requested changes Oct 3, 2024
View reviewed changes
Copy link
Contributor

@ddelgrosso1 ddelgrosso1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What happened to the kokoro changes? I saw them at one point.

ddelgrosso1
ddelgrosso1 reviewed Oct 3, 2024
View reviewed changes
system-test/storage.ts Outdated Show resolved Hide resolved
@thiyaguk09
Copy link
Contributor Author

What happened to the kokoro changes? I saw them at one point.

gcf-owl-bot removed those changes 31ca744.

ddelgrosso1
ddelgrosso1 reviewed Oct 4, 2024
View reviewed changes
.kokoro/samples-test.sh Outdated Show resolved Hide resolved
@ddelgrosso1 ddelgrosso1 added the owlbot:ignore instruct owl-bot to ignore a PR label Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ddelgrosso1 ddelgrosso1 ddelgrosso1 approved these changes

Assignees
No one assigned
Labels
api: storage Issues related to the googleapis/nodejs-storage API. owlbot:ignore instruct owl-bot to ignore a PR size: m Pull request size is medium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thiyaguk09 @ddelgrosso1 @harsha-accenture