Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: move HMAC system tests to use emulator #2461

Open
ddelgrosso1 opened this issue May 8, 2024 · 1 comment
Open

tests: move HMAC system tests to use emulator #2461

ddelgrosso1 opened this issue May 8, 2024 · 1 comment
Assignees
@ddelgrosso1
Labels
api: storage Issues related to the googleapis/nodejs-storage API. type: cleanup An internal cleanup or hygiene concern.

Comments

@ddelgrosso1
Copy link
Contributor

Per our docs there can be up to a 3 minute delay in modifying HMAC state. As such, it is occasionally causing system tests to fail. After speaking with @BenWhitehead it appears Java sidestepped this issue by using test bench. Node should do similar to avoid the flakiness. This will require separating out the HMAC tests from the larger storage.ts system-test and then reusing the infrastructure setup from conformance tests.
@ddelgrosso1 ddelgrosso1 added the type: cleanup An internal cleanup or hygiene concern. label May 8, 2024
@ddelgrosso1 ddelgrosso1 self-assigned this May 8, 2024
@product-auto-label product-auto-label bot added the api: storage Issues related to the googleapis/nodejs-storage API. label May 8, 2024
@ddelgrosso1 ddelgrosso1 mentioned this issue May 8, 2024
Merged
4 tasks
@ddelgrosso1 ddelgrosso1 mentioned this issue Jun 5, 2024
Closed
@ddelgrosso1 ddelgrosso1 mentioned this issue Jun 17, 2024
Closed
@danielduhh danielduhh mentioned this issue Jun 17, 2024
Closed
4 tasks
This was referenced Aug 1, 2024
Closed
Closed
Closed
This was referenced Aug 12, 2024
Closed
Closed
@ddelgrosso1
Copy link
Contributor Author

Please undo: #2511 once this is completed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ddelgrosso1 ddelgrosso1

Labels
api: storage Issues related to the googleapis/nodejs-storage API. type: cleanup An internal cleanup or hygiene concern.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ddelgrosso1