From 2f0cef9161fea3a4687ca47a9c68c8ba5c4c3302 Mon Sep 17 00:00:00 2001 From: Daniel Bruce Date: Fri, 29 Sep 2023 15:48:46 -0400 Subject: [PATCH 1/3] Remove workaround Remove workaround for the call to createreadstream because the issue mentioned in the comment is closed. --- test/readrows.ts | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/test/readrows.ts b/test/readrows.ts index 265125c34..ed9223142 100644 --- a/test/readrows.ts +++ b/test/readrows.ts @@ -242,12 +242,7 @@ describe('Bigtable/ReadRows', () => { let lastKeyReceived: number | undefined; // BigTable stream - const readStream = table.createReadStream({ - // workaround for https://github.com/grpc/grpc-node/issues/2446, remove when fixed - gaxOptions: { - timeout: 3000, - }, - }); + const readStream = table.createReadStream(); // Transform stream const transform = new Transform({ From 9a4703426e16f702983f65570354f26339c770d2 Mon Sep 17 00:00:00 2001 From: Daniel Bruce Date: Fri, 29 Sep 2023 15:59:28 -0400 Subject: [PATCH 2/3] Remove workaround for read stream test This PR removes the workaround for the read stream test. This may allow the tests for windows to function without being flakey. --- test/readrows.ts | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/test/readrows.ts b/test/readrows.ts index ed9223142..71deaf7ce 100644 --- a/test/readrows.ts +++ b/test/readrows.ts @@ -192,12 +192,7 @@ describe('Bigtable/ReadRows', () => { let receivedRowCount = 0; let lastKeyReceived: number | undefined; - const readStream = table.createReadStream({ - // workaround for https://github.com/grpc/grpc-node/issues/2446, remove when fixed - gaxOptions: { - timeout: 3000, - }, - }); + const readStream = table.createReadStream(); readStream.on('error', (err: GoogleError) => { done(err); }); From 01ab35b4b857e6685dbe7d610f6c8d81a695c683 Mon Sep 17 00:00:00 2001 From: Daniel Bruce Date: Fri, 29 Sep 2023 16:15:38 -0400 Subject: [PATCH 3/3] Increase the test timeout --- test/readrows.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/readrows.ts b/test/readrows.ts index 71deaf7ce..11d8a4597 100644 --- a/test/readrows.ts +++ b/test/readrows.ts @@ -220,7 +220,7 @@ describe('Bigtable/ReadRows', () => { // TODO: enable after https://github.com/googleapis/nodejs-bigtable/issues/1286 is fixed it('should be able to stop reading from the read stream when reading asynchronously', function (done) { if (process.platform === 'win32') { - this.timeout(60000); // it runs much slower on Windows! + this.timeout(600000); // it runs much slower on Windows! } // 1000 rows must be enough to reproduce issues with losing the data and to create backpressure