Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

spanner/spansql: support for Protobuf column-types #10944

Open
dfinkel opened this issue Oct 2, 2024 · 1 comment · May be fixed by #10945
Open

spanner/spansql: support for Protobuf column-types #10944

dfinkel opened this issue Oct 2, 2024 · 1 comment · May be fixed by #10945
Assignees
@harshachinta
Labels
api: spanner Issues related to the Spanner API. triage me I really want to be triaged.

Comments

@dfinkel
Copy link
Contributor

dfinkel commented Oct 2, 2024

Client

Spanner

Environment

any

Code

I'll open a PR shortly adding support to the spansql package for parsing/canonicalizing protobuf types, and adding support for CREATE/ALTER/DROP PROTO BUNDLE statements.
@dfinkel dfinkel added the triage me I really want to be triaged. label Oct 2, 2024
@product-auto-label product-auto-label bot added the api: spanner Issues related to the Spanner API. label Oct 2, 2024
@dfinkel dfinkel linked a pull request Oct 2, 2024 that will close this issue
Open
@dfinkel
Copy link
Contributor Author

dfinkel commented Oct 2, 2024

I've filed #10945 to cover this.

(As usual) I'm open to revisions/feedback.
I mostly tried to follow the local style, but probably deviated in a few places.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@harshachinta harshachinta

Labels
api: spanner Issues related to the Spanner API. triage me I really want to be triaged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(spanner/spansql): add support for protobuf column types & Proto bundles dfinkel/google-cloud-go
2 participants
@dfinkel @harshachinta