Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

auth: have quota project override in credentials package #10808

Open
codyoss opened this issue Sep 3, 2024 · 1 comment
Open

auth: have quota project override in credentials package #10808

codyoss opened this issue Sep 3, 2024 · 1 comment
Labels
type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@codyoss
Copy link
Member

codyoss commented Sep 3, 2024

We should allow users to explicitly set the value returned by quota project getter. This would also allow us to clean up so logic in the transport packages that is needed today because we can't pass the override from the client options down to the credentials package today. There is a TODO in #10807 about this work.

@codyoss codyoss added triage me I really want to be triaged. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. and removed triage me I really want to be triaged. labels Sep 3, 2024
@codyoss
Copy link
Member Author

codyoss commented Sep 3, 2024

Said logic:

qp, err := creds.QuotaProjectID(context.Background())
if err != nil {
return nil, err
}
if qp != "" {

and

qp, err := creds.QuotaProjectID(ctx)
if err != nil {
return nil, err
}
if qp != "" {

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Development

No branches or pull requests

1 participant