Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Omit nodes without attributes or relationships from included list #223

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

EugeneKostrikov
Copy link

Current implementation keeps "empty" records in the "included" list. Most commonly happens as an unwanted side effect when the client wants the ID value of the related resource only, but not the document itself. This rather complicates client-side which needs to be aware of possibly receiving records it never requested first place.

Fixes #138

Copy link

google-cla bot commented Feb 17, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

uselessly and wrong - empty relation objects included
1 participant