Fix broken ImageRescaleWrapper due to PIL's resize() change.
#220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
test_651877307
branch
3 times, most recently
from
35d5941
to
28cefb3
Compare
PIL 10.4.0's `Image.resize()` behavior causes a breakage in `ImageRescaleWrapper` due to the way numpy arrays are compared. In particular, in 10.3.0 the `size` argument was cast to a `tuple`, but not in 10.4.0 (see [changes](python-pillow/Pillow@10.3.0...10.4.0)). This has since been [reinstated](python-pillow/Pillow@936012e), but it did not make it to the 10.4.0 release. We can still change our code though, so we now simply pass a `tuple` instead of an `np.array`. PiperOrigin-RevId: 652127278
copybara-service
bot
force-pushed
the
test_651877307
branch
from
28cefb3
to
c109b8c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix broken
ImageRescaleWrapperdue to PIL'sresize()change.PIL 10.4.0's
Image.resize()behavior causes a breakage inImageRescaleWrapperdue to the way numpy arrays are compared. In particular,in 10.3.0 the
sizeargument was cast to atuple, but not in 10.4.0 (seechanges).
This has since been
reinstated,
but it did not make it to the 10.4.0 release.
We can still change our code though, so we now simply pass a
tupleinstead ofan
np.array.