PATH in Terminal is not automatically updated to include GOROOT/bin

[TLCFEM]

I think it is a bug on Windows. I vaguely remember that I used to directly invoke go in ps.

Here on linux, PATH is correctly set in terminals.

But on Windows, PATH is not updated.

Originally posted by @TLCFEM in #3522 (comment)

[TLCFEM]

Maybe this if condition shall be revised.

vscode-go/extension/src/goEnvironmentStatus.ts

Line 390 in 7252597

if (vscode.env.shell.search(/(powershell|pwsh)$/i) !== -1) {

[findleyr]

Thanks, we think this is an upstream bug, but it requires additional investigation.