Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[json type number] proto type int64 should be string #52

Open
scbizu opened this issue Dec 20, 2018 · 4 comments
Open

[json type number] proto type int64 should be string #52

scbizu opened this issue Dec 20, 2018 · 4 comments

Comments

@scbizu
Copy link
Contributor

scbizu commented Dec 20, 2018

Background:

isNumber function will convert protobuf type int64 to json type number, but the number's precision is not equal to int64 , see the spec about the proto json.

Reproduce:

image

image

@awalterschulze
Copy link
Member

awalterschulze commented Dec 20, 2018 via email

@scbizu
Copy link
Contributor Author

scbizu commented Dec 21, 2018

I want to develop a grpc tool to quickly debug my grpc methods. And I finally find that letmegrpc impl most of my feature, I am reading through letmegrpc now and doing some changes.

So, I think I can provide a PR to solve this issue.

@awalterschulze
Copy link
Member

awalterschulze commented Dec 21, 2018 via email

@scbizu
Copy link
Contributor Author

scbizu commented Dec 23, 2018

open PR at #53

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants