Example for interacting with remote file servers #1061
+346
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srijan-27
requested changes
Oct 1, 2024
Comment on lines
+1
to
+5
| HOST="localhost" | ||
| USER_NAME="anonymous" | ||
| PASSWORD="test" | ||
| PORT=21 | ||
| REMOTE_DIR_PATH="/" |
There was a problem hiding this comment.
configs ain't necessarily needed to pass within double quotes ("")
Comment on lines
+16
to
+22
| To get the list of all directories or files in the given path of the configured remote file server | ||
|
|
||
| ``` | ||
| go run main.go ls -path=<path> | ||
|
|
||
| Eg:- go run main.go ls -path=/ | ||
| ``` |
There was a problem hiding this comment.
This needs refactoring, as it seems duplicate.. Also, in below snapshot please see that copy button will copy complete block to clipboard and it won't be useful for user. Ideally, we should only add required command reference, so user can just copy and change filePath.
| func registerCreateFileCommand(app *gofr.App, fs file.FileSystemProvider) { | ||
| app.SubCommand("createfile", func(c *gofr.Context) (interface{}, error) { | ||
| fileName := c.Param("filename") | ||
| fmt.Printf("Creating file :%s", fileName) |
There was a problem hiding this comment.
shouldn't we use gofr logger instead of fmt.Printf?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description:
Additional Information:
Checklist:
goimportandgolangci-lint.Thank you for your contribution!