Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prefix for viewer #832

Open
iwpnd opened this issue Feb 17, 2022 · 2 comments
Open

prefix for viewer #832

iwpnd opened this issue Feb 17, 2022 · 2 comments

Comments

@iwpnd
Copy link
Member

iwpnd commented Feb 17, 2022

Hi there 👋

Right now the viewer sits at the root of the server. Other than something like the /metrics or /capabilities, you cannot not route to it.
While I love the viewer for debugging, I don't want just everybody to use it - so I don't want to exclude it from the build either.
There's currently an option to prefix the entire webserver, but that would only shift the root to the new prefix, with my issue persisting still.
Do you think it makes sense to optionally add a prefix for the viewer specifically? So it can live with e.g. /viewer, can be used internally but doesn't have to be exposed publicly.

@gdey
Copy link
Member

gdey commented Feb 17, 2022

There has been a request to be able to host /metrics on a different port/prefix as well. If we were to do this, I think it would make sense for both /metrics and /viewer to have the functionality.

@ARolek
Copy link
Member

ARolek commented Feb 28, 2024

I don't see any issue with this request. I just think we should consider first time UX. We want the user to get to "Ah ha" quickly, and they can do that by hitting localhost:9090. With this change the user would need to hit localhost:9090/viewer. Not a huge deal, but something to consider.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Ready
Development

No branches or pull requests

3 participants