Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Offering help if needed #27

Open
X-Ryl669 opened this issue Apr 12, 2024 · 3 comments
Open

Offering help if needed #27

X-Ryl669 opened this issue Apr 12, 2024 · 3 comments

Comments

@X-Ryl669
Copy link

X-Ryl669 commented Apr 12, 2024

Hi,

I've been linked to your repository via here.
I've implemented an update to ESP-ADF component to support the latest version and sharing I2C bus with ESP-ADF's format and ESPHome. My work is here

I think it can be useful to merge my changes (at least for using the last ESP-ADF and dependencies version). There were a lot of pitfalls I had to fix (like the esp-dsp dependency, the I2C issue, the esp-adf incompatibility with C and C++ structure definitions and so on). So it might be save you a lot of time to avoid redoing this.

Let me know if you need it.

@gnumpi
Copy link
Owner

gnumpi commented Apr 17, 2024

Hey, sounds really interesting. Do I get it right that supporting the ADF-I2C let you use the DACs and ADCs supported by the ADF-boards? I also added some DAC and ADC support to the I2S_audio component in this repository. Would be awesome to add the ADF-boards right away. Could you share a config which makes use of your change to get a better understanding?

@X-Ryl669
Copy link
Author

Do I get it right that supporting the ADF-I2C let you use the DACs and ADCs supported by the ADF-boards?

Yes. The (HW) components supported by ADF are now accessible directly and no need to replicate those in ESPHome, while still maintaining access to ESPHome's I2C devices (like AHT sensor on BOX3, Radar, etc...).

Could you share a config which makes use of your change to get a better understanding?

esphome/issues#5296 (comment)

For the change itself, please have a look here, it's not too big in fact
And BTW, Espressif merged my change to ADF to support external I2C bus integration, so the upcoming versions will have it without a link to my fork.

@gnumpi
Copy link
Owner

gnumpi commented Apr 18, 2024

Really great news! I will try to integrate the esp_codec_dev devices into the adf_pipeline component then.
Thanks for offering your help! If it's ok, I will come back to you when I have a rough beta version and see what you think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants