provide ability to define onClick callback from table without explicitly defining children

[jlgerber]

I don't see any documentation for this, but I do see a click callback on the reactable.td element. It would be great if we could define an onClick which propagates down to the individual td elements without having to explicitly supply children (ie an onClick on the actual table component, wherein I just supply data

<reactable data={ mydata } onClick={this.tableCellClicked}...

[irium]

+1 on this. Also it will be very useful to have onRowClick too.

[anyong]

Anybody made progress on this yet before I start to write it?

[glittershark]

@anyong nobody as far as I know. Let's call the event handlers themselves onTrClick and onTdClick

[idevchew]

Question - I noticed that the Td cell has a onClick callback which is assigned to handleClick at init,
When I try to pass handleClick={this.myClick} from a parent node, the myClick is not passed at all although the handleClick is being called. It seems that this is being filtered out?

I am working around this as follows

var tdEvent = new CustomEvent( 'ReactableCellEvent' , {
detail: {
cellid : e.currentTarget.id,
celldata : this.props
},
bubbles: true,
cancelable: true
});
this.getDOMNode().dispatchEvent(tdEvent );

And catching at the parent node with
this.getDOMNode().addEventListener('ReactableCellEvent', this.doCell )

And adding the same for the the Tr class

However would love to have a proper onTrClick/OnTdClick though

otherwise GREAT JOB!!

[mlucool]

👍

[cklab]

@glittershark As a related side question/discussion: any particular reason for calling the click handler handleClick instead of sticking with the expected onClick?

[felizuno]

@anyong @idevchew do either of you have pull requests to add this functionality, or does somebody else need to take it up?

[glittershark]

@cklab it's mostly historical at this point. I would actually prefer to move all event handlers to on... and deprecate the handle... ones

[hdrdavies]

@glittershark is there a onTrClick as mentioned above?

p.s. this is incredibly awesome module 😄

[tvilon]

Here is my take on adding onRowClick: #362