Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filters #3

Open
derDoc opened this issue Feb 8, 2013 · 0 comments
Open

Filters #3

derDoc opened this issue Feb 8, 2013 · 0 comments

Comments

@derDoc
Copy link

derDoc commented Feb 8, 2013

Filter handling is broken, due to the subclassing of HamlLine to HamlParser.
HamlLine does not implement the method getAsSource().
Changing line 1284 to read

$oHaml = new HamlParser($this->sPath, $this->bCompile, $parent, array('line'=>$iLine, 'file'=>$this->sFile));

however fixes this.
Furthermore, since SassParser implements sass() as a static method the callable must be passed to registerBlock in line 217 as follows:

self::registerBlock(__NAMESPACE__ .'\SassParser::sass', 'sass');

The array(instance, method) only works for non-static methods.
I will submit patches for this (or a pull request) soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant