Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

client-side cells break notebook scrolling #2

Open
jaked opened this issue Apr 24, 2024 · 2 comments
Open

client-side cells break notebook scrolling #2

jaked opened this issue Apr 24, 2024 · 2 comments

Comments

@jaked
Copy link
Collaborator

jaked commented Apr 24, 2024

When the pointer is over the rendered output of a client-side cell, scrolling (e.g. with two-finger swipe) doesn't scroll the notebook.

@jaked
Copy link
Collaborator Author

jaked commented Apr 24, 2024

what I've learned so far:

  • ordinarily when the pointer is over a scroll container, a scroll gesture causes the container to scroll to its scroll boundary; then scrolling chains up the container chain.
  • in VS Code notebooks, outputs are rendered in an iframe (a single iframe for the whole notebook), which is overlayed on the notebook; individual outputs are absolutely positioned to their correct position in the notebook.
  • client-side cells have an additional iframe that points to the vitale server; this is a cross-domain link (but here's an example of a cross-domain iframe with working scroll chaining https://csreis.github.io/tests/cross-site-iframe.html)

@jaked
Copy link
Collaborator Author

jaked commented Jun 27, 2024

I tried as best I could to reproduce the situation with a bunch of nested iframes and similar CSS, but scrolling works fine in my repro :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant