Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spurious curation log entries appearing with status changes #2044

Open
14 tasks
only1chunts opened this issue Sep 30, 2024 · 3 comments
Open
14 tasks

spurious curation log entries appearing with status changes #2044

only1chunts opened this issue Sep 30, 2024 · 3 comments

Comments

@only1chunts
Copy link
Member

only1chunts commented Sep 30, 2024

User story

As a curator
I want the curation log entry "Curator Assigned: user" to only be added when the Curator Id field is changed
So that I can know when the Curator Id is changed by looking at the curation log entries

Acceptance criteria

Given I am on a admin form for a dataset
When I chanbge anything on the page but the Curator Id
And I press Save
Then I should not see a curation log entry for "Curator Assigned:"

Given I am on a admin form for a dataset
When I changed the Curator Id field
And I press Save
Then I should see a new curation log entry "Curator Assigned: user" where user is the curator I have selected

## Additional infos

I haven't investigated properly, but it appears that "Curator Assigned:" entries are getting added to the curation log with some (maybe all) dataset status changes.
The only times the "curator assigned" entry should appear in the log is when the assigned curator field is actually changed, either from blank to a name, or when the name is changed.

image

Additional Info

Product Backlog Item Ready Checklist

  • Business value is clearly articulated
  • Item is understood enough by the IT team so it can make an informed decision as to whether it can complete this item
  • Dependencies are identified and no external dependencies would block this item from being completed
  • At the time of the scheduled sprint, the IT team has the appropriate composition to complete this item
  • This item is estimated and small enough to comfortably be completed in one sprint
  • Acceptance criteria are clear and testable
  • Performance criteria, if any, are defined and testable
  • The Scrum team understands how to demonstrate this item at the sprint review

Product Backlog Item Done Checklist

  • Item(s) in increment pass all Acceptance Criteria
  • Code is refactored to best practices and coding standards
  • Documentation is updated as needed
  • Data security has not been compromised (with particular reference to the personal information we hold in GigaDB)
  • No deviation from the team technology stack and software architecture has been introduced
  • The product is in a releasable state (i.e. the increment has not broken anything)
@tuli
Copy link

tuli commented Oct 4, 2024

@only1chunts as we are now adding a log for every event, I think this bug should be assigned a higher impact.
I've added 2 Comment to https://gigadb.org/adminDataset/update/id/2846 but it has 6 Actions.

@only1chunts
Copy link
Member Author

we dont have a "medium" impact tag, and its not a blocking thing so it doesn't fit in "high impact". Its pretty simple to delete the spurious "curator assigned" entries, but it is annoying and tedious so does need fixing.
NB - you dont need to add the date IN the comment (unless you're adding the comment at a later date), thats a few less key strokes ;-)

@tuli
Copy link

tuli commented Oct 4, 2024

we dont have a "medium" impact tag, and its not a blocking thing so it doesn't fit in "high impact". Its pretty simple to delete the spurious "curator assigned" entries, but it is annoying and tedious so does need fixing. NB - you dont need to add the date IN the comment (unless you're adding the comment at a later date), thats a few less key strokes ;-)

Yeah...I realised I was 'over dating'.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: To Estimate
Development

No branches or pull requests

3 participants