Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Need support to set dispatch type for MTLComputePassDescriptor #332

Closed
Snowapril opened this issue Aug 10, 2024 · 2 comments
Closed

Need support to set dispatch type for MTLComputePassDescriptor #332

Snowapril opened this issue Aug 10, 2024 · 2 comments

Comments

@Snowapril
Copy link

Hi. I'm trying to optimize several compute pass gpu times in wgpu for practice.
But I found that there is no way to enable MTLDispatchType::Concurrent with compute_command_encoder_with_descriptor.

If there is no specific reason not to specify MTLDispatchType while using MTLComputePassDescriptor, I would like to support it.
@Snowapril
Copy link
Author

Could I submit a pull-request for this? I already made a commit for this

@kvark
Copy link
Member

kvark commented Sep 26, 2024

Sorry for not responding to this earlier!
Generally, in a project like metal-rs, you could start a discussion with a PR right away.
Done in #335

@kvark kvark closed this as completed Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kvark @Snowapril