Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(apple): Replay Redact #11418

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

feat(apple): Replay Redact #11418

wants to merge 5 commits into from

Conversation

brustolin
Copy link
Contributor

@brustolin brustolin commented Sep 23, 2024

Adding instructions on how to use custom redact APIs for Apple SDK.

Copy link

vercel bot commented Sep 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
changelog ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 26, 2024 11:51am
develop-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 26, 2024 11:51am
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 26, 2024 11:51am

Copy link
Member

@JoshuaMoelans JoshuaMoelans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just have some minor nitpicks on grammar & small question about using ignoreView without disabling the default

Copy link

codecov bot commented Sep 26, 2024

Bundle Report

Changes will increase total bundle size by 14.09MB (99.79%) ⬆️⚠️, exceeding the configured threshold of 5%.

Bundle name Size Change
sentry-docs-server* 7.46MB 7.46MB (100%) ⬆️⚠️
sentry-docs-edge-server* 254.44kB 254.44kB (100%) ⬆️⚠️
sentry-docs-client* 6.38MB 6.38MB (100%) ⬆️⚠️
sentry-docs-server-cjs 7.45MB 228 bytes (0.0%) ⬆️
sentry-docs-edge-server-array-push 257.07kB 3 bytes (-0.0%) ⬇️
sentry-docs-client-array-push 6.42MB 6 bytes (-0.0%) ⬇️

ℹ️ *Bundle size includes cached data from a previous commit

@chargome
Copy link
Member

@brustolin please rebase this on master, then the pr should be un-blocked!

Copy link
Contributor

@lizokm lizokm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this! I left a few edits, but overall it looks great.

@@ -0,0 +1,66 @@
---
title: Using custom redact for Session Replay
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
title: Using custom redact for Session Replay
title: Using Custom Redact for Session Replay

title: Using custom redact for Session Replay
sidebar_order: 5501
notSupported:
description: "Learn how to choose which part of your app's data to redact in Session Replay."
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
description: "Learn how to choose which part of your app's data to redact in Session Replay."
description: "Learn how to redact parts of your app's data in Session Replay."

Comment on lines +8 to +12
<Note>

Using custom redaction for Session Replay can expose sensitive data. Make sure to double-check every part of your app's data that you choose to redact or not.

</Note>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<Note>
Using custom redaction for Session Replay can expose sensitive data. Make sure to double-check every part of your app's data that you choose to redact or not.
</Note>
<Alert>
If you custom redact your Session Replays, you may accidentally expose sensitive customer data. Be sure to double-check what you choose to expose.
</Alert>

Comment on lines +14 to +15
By default, our Session Replay SDK masks all text content, images, and user input, giving you heightened confidence that no sensitive data will leave the device. However, you can choose which parts of your app's data to redact or not by using some different options.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
By default, our Session Replay SDK masks all text content, images, and user input, giving you heightened confidence that no sensitive data will leave the device. However, you can choose which parts of your app's data to redact or not by using some different options.
By default, our Session Replay SDK masks all text content, images, and user input. This helps ensure that no sensitive data will be exposed. You can also manually choose which parts of your app's data to redact by using the different options listed below.

By default, our Session Replay SDK masks all text content, images, and user input, giving you heightened confidence that no sensitive data will leave the device. However, you can choose which parts of your app's data to redact or not by using some different options.


## Redact by View class
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
## Redact by View class
## Redact by View Class

options.experimental.sessionReplay.ignoreViewClasses = [MyCustomLabel.self]
```

## Redact View by instance
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
## Redact View by instance
## Redact by View Instance


## Redact View by instance

You can also choose to redact or ignore a specific view instance by using the replay API or view extensions like this:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
You can also choose to redact or ignore a specific view instance by using the replay API or view extensions like this:
You can also choose to redact or ignore a specific view instance by using the [replay API](/api/replays/) or view extensions like this:

options.experimental.sessionReplay.redactAllImages = false
```

Then you can manually choose which `View` you want to redact with the `replayRedact` modifier
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Then you can manually choose which `View` you want to redact with the `replayRedact` modifier
Then you can manually choose which `View` you want to redact with the `replayRedact` modifier:

Comment on lines +62 to +65
<Note>
Dissabling the default redaction options will expose all text and images in the session replay.
Make sure to redact them manually.
</Note>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<Note>
Dissabling the default redaction options will expose all text and images in the session replay.
Make sure to redact them manually.
</Note>
<Note>
Disabling the default redaction options will expose all text and images in the session replay.
Make sure to redact them manually.
</Note>

Comment on lines +76 to +78
The SDK is recording and aggressively redacting all text and images.
Please don't turn it off if you have sensitive data in your app.
If you want to manually choose which part of your app's data to redact, read our guide on [custom redaction](/platforms/apple/guides/ios/session-replay/customredact).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The SDK is recording and aggressively redacting all text and images.
Please don't turn it off if you have sensitive data in your app.
If you want to manually choose which part of your app's data to redact, read our guide on [custom redaction](/platforms/apple/guides/ios/session-replay/customredact).
The SDK aggressively records and redacts all text and images.
Please don't turn it off if you have sensitive data in your app.
If you want to manually redact parts of your app's data, read our guide on [custom redaction](/platforms/apple/guides/ios/session-replay/customredact).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FAQ for SwiftUI Replay Redaction
4 participants