Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LNURL-verify verifyPayment function should handle fetch errors #125

Open
rolznz opened this issue Dec 14, 2023 · 1 comment · May be fixed by #154
Open

LNURL-verify verifyPayment function should handle fetch errors #125

rolznz opened this issue Dec 14, 2023 · 1 comment · May be fixed by #154
Labels
good first issue Good for newcomers

Comments

@rolznz
Copy link
Contributor

rolznz commented Dec 14, 2023

Network errors currently are uncaught. I think for temporary errors like this we should just catch them, log the error and return false. verifyPayment is meant to be polled anyway so the next fetch should work.
@rolznz rolznz added the good first issue Good for newcomers label Dec 14, 2023
@Toheeb-Ojuolape Toheeb-Ojuolape mentioned this issue Oct 6, 2024
Closed
11 tasks
@Toheeb-Ojuolape
Copy link

Hi @rolznz I currently have a PR that addresses this. I hope you find it acceptable 🥺

@Toheeb-Ojuolape Toheeb-Ojuolape linked a pull request Oct 7, 2024 that will close this issue
Open
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
2 participants
@rolznz @Toheeb-Ojuolape