-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deal with order unavailability in the 10101 app #860
Comments
@holzeis I've included this ticket into the iteration as it clearly stems from removing the dummy price values one (and there's nothing to grab there anymore). |
this task has exploded considerably, it turns out that there's no place is the system where we prune the expired orders. |
Depends on what you mean with this. The orderbook is not considering outdated orders: 10101/coordinator/src/orderbook/routes.rs Lines 142 to 148 in 238ac9d
|
Please ping and discuss (with anyone) before you fall down the rabbit hole of refactoring the universe and everything. |
I was referring to the task, as it assumed that everything was in place for the task to be done - the backend was noticing / cleaning the orders if the coordinator or maker went offline.
that only happens in context of a |
I have in fact reached out on matrix first before I flagged this. |
as for the status: when there's no active active orders (e.g. maker / coordinator ar down), we grey out the buy/sell buttons. It's not best indicator, but it is an indicator. I would love if we started an error feed for the subscribers, so we could push them to the app. |
Ideally we should:
N/A
).Follow-up from #859 - where we can finally express lack of values from coordinator, but we still don't clear them when the node is offline.
The text was updated successfully, but these errors were encountered: