Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot trade with dlc channel in state RenewOffered #2628

Closed
holzeis opened this issue Jun 16, 2024 · 6 comments
Closed

Cannot trade with dlc channel in state RenewOffered #2628

holzeis opened this issue Jun 16, 2024 · 6 comments
Labels
bug Something isn't working

Comments

@holzeis
Copy link
Contributor

holzeis commented Jun 16, 2024

  • Rollover timed out.
  • No new rollover was attempted.
  • After expiry the position did not get closed automatically.
  • Close position button is in closing

Trying to buy $1 resulted in the reported error.

image image
@holzeis holzeis added the bug Something isn't working label Jun 16, 2024
@holzeis
Copy link
Contributor Author

holzeis commented Jun 16, 2024

It seems the app never received the RenewOffer.

@holzeis
Copy link
Contributor Author

holzeis commented Jun 16, 2024

I checked the logs, the coordinator wasn't able to store the RenewOffer dlc message, thus it is never sent in the first place, and because it wasn't stored to the database it wasn't retried on reconnects.

{"timestamp":"2024-06-14T15:18:30.520400301Z","level":"ERROR","fields":{"message":"Failed to store dlc message. timed out waiting for connection","peer":"02aa6fc81e341d69b36174365644a3560bfcc51ce0fb9bb67d93712bc54117cbb8"},"target":"coordinator::dlc_handler"}

It looks like we are too inefficient with our connection usage. Haven't checked yet, but if we use the default values 10 connections can be requested in parallel from the postgresql database. If all of them a used and not freed up in time, the client will time out.

Maybe related to some inefficiency on the rollover implementation.

@bonomat
Copy link
Contributor

bonomat commented Jun 16, 2024

If all of them a used and not freed up in time, the client will time out.

What's the timeout?

@holzeis
Copy link
Contributor Author

holzeis commented Jun 17, 2024

If all of them a used and not freed up in time, the client will time out.

What's the timeout?

#2629 (comment)

@holzeis
Copy link
Contributor Author

holzeis commented Jun 17, 2024

Closing this issue as the underlying issue is #2629 which resulted in the dlc message not getting stored to the database thus the rollover never happened. I rolled back the channel state on the coordinator and rerun the rollover which worked.

@holzeis holzeis closed this as completed Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants