Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Periodic check is called only every 30 seconds #1302

Closed
holzeis opened this issue Sep 15, 2023 · 1 comment
Closed

Periodic check is called only every 30 seconds #1302

holzeis opened this issue Sep 15, 2023 · 1 comment

Comments

@holzeis
Copy link
Contributor

holzeis commented Sep 15, 2023

When the app got restarted why the dlc protocol was still executing we have a mechanism to recover upon starting up the app again. During the channel reestablishment actions are identified that defining what messages need to be resend etc. These actions are stored into a set and are looked at by the app and the coordinator every 30 seconds. This is a very long time in which the user might already have closed the app again.

This PR #1298 helps letting the user know that something is still pending and speeds up the period check by a best effort approach, but the underlying issue should be fixed in rust-dlc.

Ideally we process any pending actions after a channel reestablishment immediately instead of looking at any pending actions every 30 seconds. It also doesn't make much sense to look at pending actions anyways if there hasn't been a recent channel reestablishment. As far as I know, there is no other place where pending actions may get created.

@github-actions
Copy link

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot added the Stale label Oct 20, 2023
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants