Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync position with dlc channel state #1273

Closed
holzeis opened this issue Sep 10, 2023 · 2 comments · Fixed by #1298
Closed

Sync position with dlc channel state #1273

holzeis opened this issue Sep 10, 2023 · 2 comments · Fixed by #1298
Assignees

Comments

@holzeis
Copy link
Contributor

holzeis commented Sep 10, 2023

Due to an error I am having an open position but a closed dlc. It would be great if the app would be smart enough to sync these states, while the DLC is the source of truth.

if DLC is in SubChannelState::Signed: Create position (take data from order) if not existing
if DLC is in SubChannelState::OffChainClosed: Delete position if still existing

would have been useful for #1257

@holzeis
Copy link
Contributor Author

holzeis commented Sep 11, 2023

Note this will also help if the channel got force closed.

@bonomat
Copy link
Contributor

bonomat commented Sep 12, 2023

Please add a MASSIVE TODO that this is not the right way to do it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants