-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make position expiry configurable #1029
Comments
Duplicate of #935 |
This is not a duplicate. The order expiry is unrelated to the position expiry. |
it's different, but of course it's related; they should be changed via the same API, and most likely tackled at the same time. |
I don't think so. |
Aren't they both essentially terms, on which maker wants to offer anything? |
Hi @klochowicz : you've been assigned to this since 2 weeks. Are you working on it? If not, please unassign yourself |
I was 90% in, but then noticed that it was removed from iteration after last objective alignment, so I focused on more pressing things. I will post it today, because it's close to completion. |
Sounds good. Thanks for clarification. |
Deprioritized for now. |
I've linked the work that I've done on this ticket, to whoever wants to pick it up. |
Can we close that ticket, now that we are using a logic to calculate the expiry time? |
I think so, changing this calculation logic with a config might be a bit too complex. |
At the moment any position expires at the next days midnight. Meaning that a position is at least 24 hours and at most 48 hours open.
This logic is hard-coded. It would be great if we could configure that, not only for testing purposes.
The text was updated successfully, but these errors were encountered: