12 13 #2525
Draft
12 13 #2525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks Stefan
This was introduced 2 weeks ago in https://review.typo3.org/c/Packages/TYPO3.CMS/+/83900 It blocks applying the latest TYPO3 security update v12.4.15
* [TASK] Streamline dependencies
This change streamlines the dependencies to a
workable set for TYPO3 v12 & v13 dual support.
Used command(s):
```terminal
composer require --dev --no-update \
"phpunit/phpunit":"^10.5" \
"typo3/cms-install":"^12.4.2 || ^13.1" \
"typo3/cms-seo":"^12.4.2 || ^13.1" \
"typo3/testing-framework":"^8.0.9"
```
* [TASK] Upgrade to `phpunit:^10` and `typo3/testing-framework:^8`
This change ...
* adjust unit- and functional test configuration for `phpunit/phpunit 10.x`
and `typo3/testing-framework 8.x`.
* modifies tests to ensure static dataprovider methods by adding php-cs-fixer
rule `php_unit_data_provider_static->force = true` [1].
* modifies tests to use phpunit attributes instead of annotations:
- @test => #[Test],
- @dataProvider => #[dataProvider()]
* removed invalid connection method mocks for old non doctrine connection
handlings and also avoid no longer existing setMethods() calls.
Used command(s):
```terminal
Build/Scripts/runTests.sh -p 8.1 -s cgl
```
[1] https://cs.symfony.com/doc/rules/php_unit/php_unit_data_provider_static.html
* [TASk] Apply code style fixes
Apply code style fixes due to missing run for
previous test adjustmens related to phpunit
raise.
Used command(s):
```terminal
Build/Scripts/runTests.sh -p 8.1 -s cgl
```
* [TASK] Adjust github action workflow name
* [TASK] Streamline Build/Scripts/runTests.sh
This change modifies the `Build/Scripts/runTests.sh`
execution wrapper to be in line with current TYPO3
core implementation.
This contains following tasks:
* Modify `Build/Scripts/runTests.sh`:
* `-b <container-binary>` switch to determine which
container binary should be used.
* Remove the usage of `docker-compose.yml` file and
usage by replacing container execution call with
docker or podman binary calls.
* Include `bash trap` logic for container/network
cleanup on abort signals.
* deprecated the `-e` option in favour of direct
command expansion using `--`.
* Refactor suit command execution without docker-compose.
* Remove `Build/testing-docker/docker-compose.yml` due
to being obsolete now.
* Add composer related temporary files to `.gitignore`
and `.gitattributes`.
* Add documentation rendering and test rendering to the
`runTests.sh`.
* Switched composer validate to remove deprecated `-e`
option usage in GitHub action workflow and added the
`--no-check-lock` option to mitigate lock file errors
due to core switches.
* [TASK] Fix tests
* [TASK] Cleanup TsConfig usage
---------
Co-authored-by: Georg Ringer <[email protected]>
Replace contents menus with confval-menu where used for properties
With PHP 8.4 marking method parameter implicitly nullable is deprecated and will emit a `E_DEPRECATED` warning. One recommended way to resolve this, is making it explicitly nullable using the `?` nullable operator or adding a null type to an union type definition. [[1]](https://php.watch/versions/8.4/implicitly-marking-parameter-type-nullable-deprecated) This prepares the way towards PHP 8.4 compatibility. * [[1] https://php.watch/versions/8.4/implicitly-marking-parameter-type-nullable-deprecated](https://php.watch/versions/8.4/implicitly-marking-parameter-type-nullable-deprecated)
* [BUGFIX] Correctly name docker network in runTests * [BUGFIX] Fix the functional tests Numerical indexes are deprecated since TYPO3 12
* [BUGFIX] Correctly name docker network in runTests * [BUGFIX] Fix the functional tests Numerical indexes are deprecated since TYPO3 12 * [TASK] Remove outdated TypoScript files with .txt ending Including these does not work anymore with TYPO3 12, see https://docs.typo3.org/c/typo3/cms-core/main/en-us/Changelog/12.0/Breaking-97816-NewTypoScriptParserInFrontend.html
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.