Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OGC API bug ignores SSL verify flag of Authentication object #865

Open
berntholer opened this issue Mar 1, 2023 · 1 comment
Open

OGC API bug ignores SSL verify flag of Authentication object #865

berntholer opened this issue Mar 1, 2023 · 1 comment
Labels

Comments

@berntholer
Copy link

Our corporate firewall inserts its own self signed certificate in the SSL chain. For quick development I usually test things using the verify=False option in request calls.

When I tested some WMS functionality of OWSlib I first created a simple Authentication object like so:

myauth=Authentication(verify=false)

Passing myauth to WebMapService(..., auth=myauth) worked as expected. But when I tried to do the same for OGC API Features(..., auth=myauth) calls I got SSL self signed certificate errors.

Upon inspecting the code I saw that the auth.verify value is never used in the http_prepare() function, unlike in the openURL() function used for i.e. WMS.

I created a PR to fix this 37cfb31

PS I assume another potential problem lies with the pop() statements like this followed by a get() later on here which will always be empty since the value was popped out of the dictionary?

Copy link

github-actions bot commented Oct 6, 2024

This Issue has been inactive for 90 days. In order to manage maintenance burden, it will be automatically closed in 7 days.

@github-actions github-actions bot added the stale label Oct 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant