Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent autocomplete behaviour #131

Open
frafra opened this issue Jun 30, 2021 · 3 comments
Open

Inconsistent autocomplete behaviour #131

frafra opened this issue Jun 30, 2021 · 3 comments
Assignees

Comments

@frafra
Copy link
Contributor

frafra commented Jun 30, 2021

Leaving it empty is OK (even if it is mandatory - could it be related to #130?), but if it is emptied, the last selection is kept. This also happens if the user types something incorrect.

@moovida
Copy link
Member

moovida commented Jul 14, 2021

This is related to #130 , yes.

I was wondering about the incorrect typing. To be honest I would find this a good thing. If the needed option is not there, it would still be possible to add it?

@moovida moovida self-assigned this Jul 14, 2021
@frafra
Copy link
Contributor Author

frafra commented Aug 3, 2021

I see two possibilities when there is an invalid input:

  • An error is raised, and the wrong data is not store (the user should still be warned about that)
  • No error or warning is raised, and the invalid data is stored

Both options make sense to me. I would prefer the first, but a flag could be set to switch between the two behaviours.

@frafra
Copy link
Contributor Author

frafra commented Aug 16, 2021

I just want to add that if the form input is emptied, the last selection is kept, even if an item with an empty value is specified in tags.json, so an emptied selection should be valid technically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants