Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamically hide unimportant parts of the Confirm Install text #1106

Open
xparadoxical opened this issue Oct 3, 2024 · 1 comment
Open

Comments

@xparadoxical
Copy link
Contributor

Geode Version

3.8.1

Related Problem

You get thrown everything at you at once, while in the below case, half of the present information (2/5 of the presented numbers) is actually important:

  • that 1 mod will be installed
  • and that it's incompatible with 2 enabled mods.

image

Your Solution

Only show info with non-zero values, e.g. in the above case show the popup with:

1 mods will be installed. 
2 mods will be force-disabled, as they are incompatible: (non-empty list)

Additional Information

For quick reference, this is where the popup text is constructed

fmt::format(
"<cj>{}</c> mods will be installed, of which <cy>{}</c> are <cy>dependencies</c> and <cy>{}</c> are <cy>replacements</c>.\n"
"<cr>{} mods will be force-disabled, as they are incompatible</c>: {}\n"
"<cg>{} mods will be force-enabled</c>: {}",
toConfirm.modCount, toConfirm.dependencyCount, toConfirm.replacementCount,
idsToDisable.size(), joinIdsToIDs(idsToDisable),
toConfirm.toEnable.size(), joinModsToIDs(toConfirm.toEnable)
),

@Fleeym
Copy link
Contributor

Fleeym commented Oct 3, 2024

This seems like a good idea, will try and implement 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants