Skip to content
This repository has been archived by the owner on Nov 24, 2020. It is now read-only.

Colors module #37

Open
emgrav opened this issue Sep 20, 2013 · 4 comments
Open

Colors module #37

emgrav opened this issue Sep 20, 2013 · 4 comments

Comments

@emgrav
Copy link
Contributor

emgrav commented Sep 20, 2013

Aside from testing it, I haven't seen anyone use the color module since it was implemented. It takes up a large portion of the entire DB, we could cut down on the size by removing the module.

Opinions?
@Gissues:{"order":33.33333333333332,"status":"backlog"}

@codyharrington
Copy link
Member

I wouldn't mind

@Mechazawa
Copy link
Member

I'm all for removing it

@Nyubis
Copy link
Contributor

Nyubis commented Jan 19, 2014

If the database size is the real problem, you can just disable the module by removing it from __init__.py, so the database table won't be created by default for anyone installing the bot.

Then again, I don't really see what the purpose of the of the module was in the first place, so unless anyone considers the code to have any particular educational value, we might as well remove the whole thing altogether.

@emgrav
Copy link
Contributor Author

emgrav commented Jan 19, 2014

The color module has to my knowledge never been used apart from when it was created, I'll disable it from SICPBot when I get around to it. Feel free to at least disable it per default for new users.

Nyubis [email protected] wrote:

If the database size is the real problem, you can just disable the
module by removing it from init.py, so the database table won't be
created by default for anyone installing the bot.

Then again, I don't really see what the purpose of the of the module
was in the first place, so unless anyone considers the code to have any
particular educational value, we might as well remove the whole thing
altogether.


Reply to this email directly or view it on GitHub:
#37 (comment)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants