Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some SynGO evidence codes are no longer children of IDA #5

Closed
kltm opened this issue May 10, 2022 · 10 comments
Closed

Some SynGO evidence codes are no longer children of IDA #5

kltm opened this issue May 10, 2022 · 10 comments
Labels

Comments

@kltm
Copy link
Member

kltm commented May 10, 2022

In the SynGO data, these evidence codes should be replaced so that they map up to IDA:

  • ECO:0000164 electrophysiology assay evidence > should be changed to ECO:0006006 electrophysiology assay evidence used in manual assertion
  • ECO:0001120 radioisotope assay evidence > should be changed to ECO:0001254 radioisotope assay evidence used in manual assertion
  • ECO:0005593 immunodetection assay evidence > ECO:0007719 immunodetection assay evidence used in manual assertion
  • ECO:0006065 in vitro cell based assay evidence used in manual assertion > obsolete, should be replaced by ECO:0007695
    name: cell-based assay evidence used in manual assertion

Tagging @pgaudet @dustine32

@kltm kltm added the bug label May 10, 2022
@pgaudet
Copy link

pgaudet commented May 10, 2022

@ftwkoopmans Can you change the SynGO data as shown in the previous comment and generate a new json file? We could then reload the SynGO data and have everything consistent.

Thanks, Pascale

@dustine32
Copy link
Contributor

Noting that ECO:0006065 is no longer present in the latest JSON file (SynGO_export_2021-02-25.json) so this term's usage appears to already be "fixed" in the upstream. The reason we are currently seeing ECO:0006065 coming out of Noctua is because an older JSON file (SynGO_export_2018-03-17.json) is still loaded into Noctua production.

The other evidence terms ECO:0000164, ECO:0001120, ECO:0005593 are still in the latest (2021-02-25) file and will need to be addressed.

@ftwkoopmans
Copy link
Collaborator

I've updated the JSON and uploaded it just now

@dustine32
Copy link
Contributor

Thank you so much @ftwkoopmans!

@kltm kltm changed the title Some SynGI evidence codes are no longer children of IDA Some SynGO evidence codes are no longer children of IDA May 10, 2022
@kltm
Copy link
Member Author

kltm commented May 10, 2022

@dustine32 Sorry to keep bugging you today, but I believe the next steps would be:

  • updating the models in syngo-go-cam
  • coordinating an "overlay" event during one of the future outages (so we don't get too wonky with master being out of sync)

@kltm
Copy link
Member Author

kltm commented May 10, 2022

Pinging @vanaukenk to make sure that the second one there is on our radar.

@dustine32
Copy link
Contributor

@kltm That's correct. I've been meaning to dust off syngo2lego for a long while.

@pgaudet
Copy link

pgaudet commented Jul 4, 2022

Can this be closed @kltm ?

@kltm
Copy link
Member Author

kltm commented Jul 5, 2022

@pgaudet Techincally not fixed in production, so moved to clearing until finalized.

@kltm
Copy link
Member Author

kltm commented Sep 24, 2022

release is out.

@kltm kltm closed this as completed Sep 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

4 participants