Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for PANTHER IDs in column 4 of input format #3

Open
kltm opened this issue Jun 26, 2019 · 6 comments
Open

Add support for PANTHER IDs in column 4 of input format #3

kltm opened this issue Jun 26, 2019 · 6 comments

Comments

@kltm
Copy link
Member

kltm commented Jun 26, 2019

To support new use cases from @ValWood , PANTHER IDs should be supported in addition to the regular gene products in column 4, filtering down on PANTHER families.

@kltm
Copy link
Member Author

kltm commented Jun 26, 2019

@ValWood IT might be good to get some example input to work with.

@ValWood
Copy link

ValWood commented Jul 8, 2019

Hi Seth,

Here are the current rules in a new test file using PANther IDs for exceptions
new_rules.txt

@kltm
Copy link
Member Author

kltm commented Jul 8, 2019

@ValWood Thank you for the examples. I'm wondering about the first line, which seems to start with a tab. What are the expected semantics for that (if not a copy error)?

@ValWood
Copy link

ValWood commented Jul 9, 2019

That was a bug when I exported from the spreadsheet that I am using to build.
Delete the first line to use this for testing.

I am refining a few more rules today if I get chance so I will hopefully send the final version for the publication quite soon.

@ValWood
Copy link

ValWood commented Jul 11, 2019

New rules, formatting issue resolved

new_rules.txt

@kltm
Copy link
Member Author

kltm commented Jul 11, 2019

@ValWood Great, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants