Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure new PRO IDs are available via automated pipeline #73

Closed
hdrabkin opened this issue Jan 22, 2019 · 19 comments
Closed

Ensure new PRO IDs are available via automated pipeline #73

hdrabkin opened this issue Jan 22, 2019 · 19 comments

Comments

@hdrabkin
Copy link

I had created 6 new PRO ids and they became available in our MGI GO EI on Friday. That means they are in the mgi.gpi, (I verified) which I expected would then make them available in Noctua today but they are not there.
PR:000050039
PR:000050038
PR:000050037
PR:000050036
PR:000050035
PR:000050034

@kltm
Copy link
Member

kltm commented Jan 23, 2019

@hdrabkin The NEO pipeline is currently running only as a manual operation due to issues we had recently (see geneontology/neo#38 (comment) ). We are working towards getting this into our pipeline, let's duplicate this onto #35

@kltm kltm closed this as completed Jan 23, 2019
@kltm kltm added the duplicate label Jan 23, 2019
@hdrabkin
Copy link
Author

Hi Seth
We have another new ID in our GPI that needs to get into Noctua
PR:A0A1W6AWH1

@kltm
Copy link
Member

kltm commented May 22, 2019

@hdrabkin I believe that this should be cleared on the completion of https://github.com/geneontology/noctua/issues/612

@hdrabkin
Copy link
Author

Hi Seth
Can we re-run to get in our most recent ids for Noctua use.
PR:000050193 and PR:000050194?
they are in our GPI

@kltm
Copy link
Member

kltm commented Jul 24, 2019

@kltm
Copy link
Member

kltm commented Jul 25, 2019

@hdrabkin This should be done.

@kltm kltm closed this as completed Jul 25, 2019
@hdrabkin
Copy link
Author

This issue is still not resolved.
PR:000050190 for a nuclear form of Bmp2 is available in your EI but is still not available in Noctua.
Here is the entry in our gpi
PR 000050190 mBMP2/iso:m2 bone morphogenetic protein 2 isoform m2 (mouse) protein taxon:10090 MGI:MGI:88177

@kltm
Copy link
Member

kltm commented Aug 29, 2019

@hdrabkin How recent is that? I put out a release on the 20th.

@hdrabkin
Copy link
Author

It's very old now. This is the one I had mentioned before. The term was created 6/14/2019; it is not new. I was just getting around to trying to curate it in Noctua now. I assumed the 7/25 fix would have fixed the issue.

@kltm kltm reopened this Aug 29, 2019
@cmungall
Copy link
Member

neo jobs failing on memory error
https://build.berkeleybop.org/job/build-noctua-entity-ontology/

@kltm
Copy link
Member

kltm commented Aug 30, 2019

Good catch, I forgot that we are not completing the circle with NEO yet. Perhaps we should just go ahead and put the old job to bed, we have a stub already for the S3 push: https://github.com/geneontology/pipeline/blob/issue-35-neo-test/Jenkinsfile#L213

There might still be timing issues with S3 updating, etc., but I can think of no real reason to keep the old job around. I'd propose that NEO is just another pipeline at the top level, functionally the same as https://github.com/geneontology/pipeline/blob/issue-35-neo-test/Jenkinsfile , or that we fold it into the main GO pipeline (which we tried a while back but got a little complicated).

@kltm
Copy link
Member

kltm commented Aug 30, 2019

@cmungall That said, any thoughts as to changes that would push it over the edge as far as memory goes over the last month?

@kltm
Copy link
Member

kltm commented Sep 4, 2019

@balhoff Unfortunately, @cmungall may not be available for a little bit. Would you happen to have any idea for the memory increase? If not, I'll probably move forward with getting the first idea above implemented.

@balhoff
Copy link
Member

balhoff commented Sep 5, 2019

@kltm I updated the owltools memory allowance in the Jenkins job (export OWLTOOLS_MEMORY=32G) and started a run. We may want to move this into the NEO makefile itself. I'll see if the job is successful.

@balhoff
Copy link
Member

balhoff commented Sep 5, 2019

Looks like we had a success.

@kltm
Copy link
Member

kltm commented Sep 5, 2019

@balhoff Awesome--I didn't know you had access. I'll rerun the side job and we can talk about getting rid of the legacy job when @cmungall is available.

@kltm kltm changed the title New PRO ids not available Ensure new PRO IDs are available via automated pipeline Sep 5, 2019
@kltm
Copy link
Member

kltm commented Sep 6, 2019

Hrm.
@balhoff I just did a rollout and http://noctua-amigo.berkeleybop.org/amigo/term/PR:000050190 does not appear to be there. I'll try again tomorrow; if I fail, maybe we can make a little time to dig in to why that's not getting out?

@hdrabkin
Copy link
Author

hdrabkin commented Sep 6, 2019

Have reverified that it IS in current GPI
grep of gpi ($grep '000050190' mgi.gpi
PR 000050190 mBMP2/iso:m2 bone morphogenetic protein 2 isoform m2 (mouse) protein taxon:10090 MGI:MGI:88177

@balhoff
Copy link
Member

balhoff commented Sep 9, 2019

I'm guessing you get NEO via its inclusion within go-lego. I see this ID in NEO now, but it isn't yet in go-lego. We need a snapshot success for that.

@kltm kltm closed this as completed Oct 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants