Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove old in_taxon triples when saving #503

Open
balhoff opened this issue Oct 14, 2022 · 5 comments · May be fixed by #504
Open

remove old in_taxon triples when saving #503

balhoff opened this issue Oct 14, 2022 · 5 comments · May be fixed by #504
Labels

Comments

@balhoff
Copy link
Member

balhoff commented Oct 14, 2022

Minerva calculates related taxa, based on gene products, each time it saves a model. It seems like these persist even if those genes are removed from the model. Minerva should clear old taxon assignments before calculating.

See geneontology/go-annotation#4248

@balhoff
Copy link
Member Author

balhoff commented Oct 17, 2022

@kltm I have a fix in #504, which has also been merged to the dev branch for testing. With these changes this issue is self-correcting if a problem model is opened and saved.

@kltm
Copy link
Member

kltm commented Oct 17, 2022

@balhoff @vanaukenk The choices are as follows then:

  • allow people to know about the problem, open suspect models, make a change (I assume this is a prerequisite), and then save
  • since the list is not that long, a group of us do this for users
  • we remove the bad model-level annotations through some other TBD bulk process at the next outage

@kltm
Copy link
Member

kltm commented Oct 17, 2022

@balhoff @vanaukenk I'll put this up on noctua-dev ASAP.

@kltm
Copy link
Member

kltm commented Oct 17, 2022

Experimenting a little w/@balhoff, it looks like the person who saves gets credit. I think that that might make number "2" above a little unpalatable.

@kltm
Copy link
Member

kltm commented Nov 4, 2022

@vanaukenk Just checking in on this. Are we satisfied enough to have this go in during the next outage and do we want to do more than let users naturally solve this problem over time? (I'm think there might have been another ticket or gist for this too...)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging a pull request may close this issue.

2 participants