Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Guide users to collection builders #18704

Open
mvdbeek opened this issue Aug 14, 2024 · 0 comments · May be fixed by #18857
Open

Guide users to collection builders #18704

mvdbeek opened this issue Aug 14, 2024 · 0 comments · May be fixed by #18857

Comments

@mvdbeek
Copy link
Member

mvdbeek commented Aug 14, 2024

Many users don't really know how to create collections of the right type. We now display the required collection type in data collection parameters:
Screenshot 2024-08-14 at 13 27 39

Instead of a simple text message we should have a button that opens up the appropriate collection builder (list or list:paired for simple lists, for complex types the rule builder, xref #11690) with items populated from the history (and an option to kick into the data uploader eventually).

In the context of no-history environments like brc-analytics the history might just serve as a list of recently uploaded items and the focus would be on new uploads.

@ahmedhamidawan you were interested in this issue, let me know if you need more details.

ahmedhamidawan added a commit to ahmedhamidawan/galaxy that referenced this issue Sep 19, 2024
This is an initial/draft implementation. Some of the next steps are:
- By default, instead of the modals treating the items as selections from the current history, automatically filter items valid for the list (e.g.: a list with csv elements).
- In case nothing can be auto paried for `list:paired`, do not attempt to auto pair by default and simply show all items.
- In case the current history is empty and to make it clearer in general, allow history to be switched from within the modal?
- Allow files to be uploaded (and dropped) directly to either the form field or within the list builder once it is opened.

One thing I have not planned as the initial step is the rule builder. I can see that for `list` and `list:paired`, we get that from the `props.collectionTypes` in `FormData`. But when would we use the rule builder instead?

Fixes galaxyproject#18704
ahmedhamidawan added a commit to ahmedhamidawan/galaxy that referenced this issue Sep 19, 2024
This is an initial/draft implementation. Some of the next steps are:
- By default, instead of the modals treating the items as selections from the current history, automatically filter items valid for the list (e.g.: for a list with csv elements, filter out csvs from the history in this list).
- In case nothing can be auto paried for `list:paired`, do not attempt to auto pair by default and simply show all items.
- In case the current history is empty and to make it clearer in general, allow history to be switched from within the modal?
- Allow files to be uploaded (and dropped) directly to either the form field or within the list builder once it is opened.

One thing I have not planned for yet is the rule builder. I can see that for `list` and `list:paired`, we get that from the `props.collectionTypes` in `FormData`. But when would we use the rule builder instead?

Fixes galaxyproject#18704
@ahmedhamidawan ahmedhamidawan linked a pull request Sep 19, 2024 that will close this issue
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants