Support AndroidManifest without package name

[marcin-michalek]

Hello,

first - thanks for Quadrant :)

Secondly I wanted to ask if it is possible to use it when there is AndroidManifest without package attribute (but instead there is namespace in build.gradle which is now the default way I think).
Currently when refactoring AndroidManifests and removing package the constans generated by Quadrant also loose the package prefix.

[gaelmarhic]

Cześć Marcin!

Thank you for reaching out!

Which version of Quadrant are you using?

There was a PR from @MasaHirano, a few months ago, which added support for the namespace declared in Gradle files.

Have you tried version 1.9.1?

Dziękuję :)

[marcin-michalek]

Cześć :)

Yeah, that's correct I was using 1.7 during the tests. Wanted to update to 1.9.1 but I have some trouble. On Quadrant 1.9.1 and Gradle 8.7 I have a weird issue. I am applying Quadrant in one navigation module only. When using 1.9.1 I can see Gradle task in the task list navigation/quadrant/generateActivityClassNameConstants but when launching it Gradle says:

Task 'generateActivityClassNameConstants' not found in project ':navigation'.

(similar when launching the task from terminal using gradlew).

When I keep the Gradle version and only downgrade Quadrant to 1.8 this works fine.
Maybe I can check and prepare a minimal repo to reproduce if that would be helpful.

Cheers :)

[gaelmarhic]

Hey Marcin!

Yes, a minimal repo could definitely help understand what's going on!

[soochun-deali]

Quadrant Sample.zip

First of all, your library is really awesome, and I am very grateful to use it.

I also encountered the same issue when upgrading from version 1.8 to 1.9.1.

So, I created a sample for you. I would appreciate it if you could take a look.

Additionally, when I run the project, it builds and runs fine. However, if I build it using Build > Make Project (or build from the terminal), I encounter an error.
Therefore, in my project, it runs fine in Android Studio, but the same error occurs on the build server.
It seems to be related to whether or not I use the convention plugin in the mylibrary module, as this affects the success or failure of the build.

[gaelmarhic]

Hi there @soochun-deali 👋 ,
Thanks for reaching out.
I downloaded and tested the sample project you provided.
Regarding the second issue (the one that corresponds to the screenshot), I could reproduce it consistently.
I believe it happens because it uses the version 1.7 of Quadrant.
There was a PR that fixes that particular issue. It is available from version 1.8 on.
Regarding the other issue, which is the one that @marcin-michalek was mentioning, I could not reproduce it at all...
Could you provide a sample project where it does happen?
Many thanks!
Gaël

[gaelmarhic]

@marcin-michalek Are you still getting that issue?

[keith30xi]

We are also seeing this issue. It seems like the generateActivityClassNameConstants task is not registering when run on a no-daemon gradle. Perhaps this is related to newer Gradle versions.