Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Presence of both access_id and access_url in a response #360

Open
hannes-ucsc opened this issue Jul 20, 2021 · 4 comments
Open

Presence of both access_id and access_url in a response #360

hannes-ucsc opened this issue Jul 20, 2021 · 4 comments
Labels
Compliance Issue contains something that could be covered by a test in compliance suite

Comments

@hannes-ucsc
Copy link

hannes-ucsc commented Jul 20, 2021

I interpret this clause of the spec

Note that at least one of `access_url` and `access_id` must be provided.

to mean that having both access_id and access_url in a response is acceptable. Is that the case?

If so, what is the point of providing an access ID and following it in a separate request, when a URL is already available?

@trbica
Copy link

trbica commented Jan 19, 2022

Providing both access_id and access_url in a response is misleading for DRS API client and is not aligned with Fetching DRS Objects section. DRS API client MUST only work with access_url to access DRS object content.
I would also like to hear more about resolving this as it is creating issues on the consumer side.

@nmalfroy
Copy link

I would argue the documentation that @hannes-ucsc points explicitly states that both are legitimate. Also, for signed URLs, then you would definitely not use access_url

@hannes-ucsc
Copy link
Author

I'd consider the possibility that the phrase "at least one of" was a mistake and that the intent was "either one of".

@nmalfroy
Copy link

Yeah, I agree...it appears that this may be a bug in the spec wording...which would then break our implementation

@ianfore ianfore added the Compliance Issue contains something that could be covered by a test in compliance suite label Mar 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Compliance Issue contains something that could be covered by a test in compliance suite
Projects
None yet
Development

No branches or pull requests

4 participants