-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a password validator #12
Merged
Merged
Changes from 1 commit
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,18 @@ | ||
// Package validation provides validation for data inside widgets | ||
package validation // import "fyne.io/x/fyne/data/validation" | ||
|
||
import ( | ||
"fyne.io/fyne/v2" | ||
gpv "github.com/wagslane/go-password-validator" | ||
) | ||
|
||
// NewPassword returns a new validator for validating passwords. | ||
// Validate returns nil if the password entropy is greater than or equal | ||
// to the minimum entropy. If not, an error is returned that explains | ||
// how the password can be strengthened. Advice on entropy value: | ||
// https://github.com/wagslane/go-password-validator/tree/main#what-entropy-value-should-i-use | ||
func NewPassword(minEntropy float64) fyne.StringValidator { | ||
return func(text string) error { | ||
return gpv.Validate(text, minEntropy) | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,21 @@ | ||
package validation_test | ||
|
||
import ( | ||
"testing" | ||
|
||
"fyne.io/x/fyne/data/validation" | ||
|
||
"github.com/stretchr/testify/assert" | ||
) | ||
|
||
func TestPassword(t *testing.T) { | ||
pw := validation.NewPassword(100) | ||
|
||
assert.NoError(t, pw("5 horses Ran around")) | ||
assert.Error(t, pw("bad-password")) | ||
|
||
pw = validation.NewPassword(150) | ||
|
||
assert.NoError(t, pw("7-BreaD-Crumbs.^_SpeciaL")) | ||
assert.Error(t, pw("12345--12345")) | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is missing a newline between the import groups.
Maybe we have not got the full suite of checks running on this repo yet?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The workflow is a few versions behind, but still fully functional. My editor formats stuff on save as well, it did not catch it and running goimports locally also does not correct it. I think it might be the explicit import name that makes it wonky. Either way, fixed now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not fixed now, sorry. As we are in an external project (fyne-x) the fyne.io imports come before github.com due to alphabetical ordering of external imports
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point. Thinking about this again, there probably should not be a newline between them, as we are not in the same repository.