-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Why bundle cssbeautify? #18
Comments
I agree for sure. This was done as a feature request for someone a while back, But yes next time I think I should be more assertive about these things and focus on what this module needs to do. Thanks! |
Rather than closing the issue, a better solution would be to remove this functionality and release a new major version. 😉 |
Aha, but wouldn't that be blindly accepting another feature request? Something that I've now learnt from... 😉 Feel free to prepare a PR for things like this though if you feel it's the right thing to do! Because I do appreciate the advice on the right way to do these things 👍 |
Also, it would make more sense architecturally speaking if we are to convert this to use PostCSS. A PostCSS plugin should take in an AST and return the transformed AST, not a string of CSS. 😃 Yep, not having some features is also a feature. This is why if we do this change, we should do a major version bump. |
I think I'm going to book some time to work on this and a few other modules for a personal development day at work soon. It'd be good to collaborate on some ideas and hopefully give it a good overhaul! |
This reverts commit be4e8c5.
It detracts from the scope of the module, which is just to combine media queries together. Node modules should be small, focused and efficient. Do one thing and do it well.
The text was updated successfully, but these errors were encountered: