Enhance consensus hook and relay chain configuration in cumulus parachain system #786
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/description |
|
/describe |
github-actions
bot
changed the title
|
PR Description updated to latest commit (68a78b5) |
|
/describe |
github-actions
bot
changed the title
|
PR Description updated to latest commit (0c3c794) |
luispdm
reviewed
Sep 20, 2024
| @@ -39,11 +39,27 @@ impl cumulus_pallet_parachain_system::Config for Runtime { | |||
| type XcmpMessageHandler = XcmpQueue; | |||
| type ReservedXcmpWeight = ReservedXcmpWeight; | |||
| type CheckAssociatedRelayNumber = cumulus_pallet_parachain_system::RelayNumberStrictlyIncreases; | |||
| type ConsensusHook = cumulus_pallet_parachain_system::ExpectParentIncluded; | |||
| type ConsensusHook = ConsensusHook; | |||
There was a problem hiding this comment.
Please, add the note regarding ExpectParentIncluded, as this type "handles the migration to asynchronous backing gracefully", as per polkadot-sdk docs -> https://docs.rs/cumulus-pallet-parachain-system/latest/cumulus_pallet_parachain_system/consensus_hook/struct.ExpectParentIncluded.html and merge the PR
luispdm
approved these changes
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
enhancement
Description
FixedVelocityConsensusHook.Changes walkthrough 📝
cumulus_parachain_system.rs
Enhance consensus hook with fixed velocity configurationruntime/laos/src/configs/cumulus_parachain_system.rs
ConsensusHooktype to a new implementation.ConsensusHookwith specific parameters.