-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removal of the Living Assets Ownership Pallet #171
Conversation
ecf9a8f
to
3d41a53
Compare
/describe |
/review |
PR Analysis
PR Feedback
How to use
|
08339df
to
a83dc94
Compare
393fcde
to
6d5f1c7
Compare
the change request expose a problem in the design. However we won't address it now but fix the behavior. |
@@ -61,18 +49,12 @@ where | |||
// Non-Frontier specific nor Ethereum precompiles : | |||
// a if a == hash(1024) => Some(Sha3FIPS256::execute(handle)), | |||
a if a == hash(1025) => Some(ECRecoverPublicKey::execute(handle)), | |||
a if a == hash(1026) => Some(LivingAssetsPrecompile::execute(handle)), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should be removed from pub fn used_addresses()
as well
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
fix format format removed test add runtime to mocks fix precompile test Fix conflicts
8b7c2bd
to
a73bac2
Compare
PR Type:
Refactoring
PR Description:
This PR focuses on the removal of the Living Assets Ownership Pallet from the ownership-chain project. The changes include:
PR Main Files Walkthrough:
files:
ownership-chain/runtime/src/precompiles/mod.rs
: The Living Assets Ownership Pallet related precompiles and types have been removed. This includes the removal of theLivingAssetsPrecompile
andErc721
types, and their associated execution in theexecute
function. Theis_precompile
function has also been updated to remove the check for collection addresses.ownership-chain/pallets/living-assets-ownership/src/lib.rs
: The entire file has been deleted as part of the removal of the Living Assets Ownership Pallet.ownership-chain/precompile/living-assets/src/lib.rs
: The entire file has been deleted as it was part of the Living Assets Ownership Pallet precompiles.ownership-chain/precompile/erc721/src/lib.rs
: The entire file has been deleted as it was part of the ERC721 precompiles associated with the Living Assets Ownership Pallet.ownership-chain/pallets/living-assets-ownership/Cargo.toml
: The entire file has been deleted as it was the Cargo.toml file for the Living Assets Ownership Pallet.