Fixing NewCollection Event and Updating Tests #127
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/describe |
github-actions
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type:
Bug fix
PR Description:
This PR fixes the NewCollection event in the LaosEvolution module by changing the log3 method to log2 and adjusting the parameters accordingly. It also updates the corresponding tests to reflect these changes.
PR Main Files Walkthrough:
files:
evolution-chain/precompile/laos-evolution/src/lib.rs: The log3 method in the create_collection function has been changed to log2. The parameters have been adjusted accordingly, with the collection_id now being written using the EvmDataWriter.evolution-chain/precompile/laos-evolution/src/tests.rs: The tests have been updated to reflect the changes in the NewCollection event. The mock data used in the create_collection_should_generate_log test has been updated, and the assertions have been adjusted to match the new log2 method.