Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manage versions by scm tags #71

Open
J535D165 opened this issue Dec 24, 2022 · 4 comments
Open

Manage versions by scm tags #71

J535D165 opened this issue Dec 24, 2022 · 4 comments
Assignees
Labels
enhancement New feature or request

Comments

@J535D165
Copy link

Using scm tags for versioning would be very useful imo. For example by implementing https://github.com/pypa/setuptools_scm

@J535D165 J535D165 added the enhancement New feature or request label Dec 24, 2022
@fpgmaas
Copy link
Owner

fpgmaas commented Dec 26, 2022

Thanks for the suggestion. Can you explain why this would be useful or what problem this solves? I am trying to understand it from their documentation, but I find it a bit vague. Would this be a replacement for this line?:

poetry version $RELEASE_VERSION

@J535D165
Copy link
Author

J535D165 commented Jan 9, 2023

It is not my lack of experience with poetry, hopefully, but the version is hardcoded in the pyproject.toml file. See

Or is this completely ignored?

@synacktraa
Copy link

@fpgmaas I think we can make good use of poetry's dynamic versioning. Here is an example: https://github.com/BrianPugh/python-template/blob/main/pyproject.toml

@J535D165
Copy link
Author

I agree. Could be nice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants